Thread

  1. Buffer overflow in contrib/test_parser/test_parser.c

    Paul Guyot <pguyot@kallisys.net> — 2012-01-09T23:18:59Z

    Hello,
    
    There is a buffer overflow in sample code's test_parser.c that can yield to a segmentation fault. The next byte of the buffer is tested against ' ' before its availability is checked.
    
    You will find attached a simple patch that fixes the bug.
    
    Paul
    -- 
    Semiocast            http://semiocast.com/
    +33.183627948 - 20 rue Lacaze, 75014 Paris
    
  2. Re: Buffer overflow in contrib/test_parser/test_parser.c

    Tom Lane <tgl@sss.pgh.pa.us> — 2012-01-10T00:40:51Z

    Paul Guyot <pguyot@kallisys.net> writes:
    > There is a buffer overflow in sample code's test_parser.c that can yield to a segmentation fault. The next byte of the buffer is tested against ' ' before its availability is checked.
    
    Hmm, yeah.  The probability of a failure is very low of course, but
    still it'd be better if the sample code didn't have bugs like this.
    
    > You will find attached a simple patch that fixes the bug.
    
    Will apply, thank you.
    
    			regards, tom lane