Re: Buffer overflow in contrib/test_parser/test_parser.c

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Paul Guyot <pguyot@kallisys.net>
Cc: pgsql-hackers@postgresql.org
Date: 2012-01-10T00:40:51Z
Lists: pgsql-hackers
Paul Guyot <pguyot@kallisys.net> writes:
> There is a buffer overflow in sample code's test_parser.c that can yield to a segmentation fault. The next byte of the buffer is tested against ' ' before its availability is checked.

Hmm, yeah.  The probability of a failure is very low of course, but
still it'd be better if the sample code didn't have bugs like this.

> You will find attached a simple patch that fixes the bug.

Will apply, thank you.

			regards, tom lane