Re: [HACKERS] CLUSTER command progress monitor

Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>

From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Rafia Sabih <rafia.pghackers@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dmitry Dolgov <9erthalion6@gmail.com>, Peter Geoghegan <pg@bowt.ie>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Jeff Janes <jeff.janes@gmail.com>, Thomas Munro <thomas.munro@enterprisedb.com>, Michael Paquier <michael.paquier@gmail.com>

Date: 2019-03-25T01:01:46Z

Lists: pgsql-hackers

Attachments

progress_monitor_for_cluster_command_v12.patch (text/x-patch) patch v12
test_result.txt (text/plain)

Hi Robert!

On 2019/03/23 3:31, Robert Haas wrote:
> On Tue, Mar 19, 2019 at 2:47 PM Robert Haas <robertmhaas@gmail.com> wrote:
>> how close you were getting to rewriting the entire heap.  This is the
>> one thing I found but did not fix; any chance you could make this
>> change and update the documentation to match?
> 
> Hi, is anybody working on this?

I sent this email using my personal email address: yamatattsu@gmail-.
I re-send it with the patch and my test result.

Thank you so much for reviewing the patch and sorry for the late reply.
Today, I realized that you sent the email for the patch because I took a
sick leave from work for a while. So, I created new patch based on your comments asap.
I hope it is acceptable to you. :)

Changes
   - Add new column *heap_tuples_written* in the view
       This column is updated when the phases are "seq scanning heap",
       "index scanning heap" or "writing new heap".
   - Fix document
   - Revised the patch on the current head: 940311e4bb32a5fe99155052e41179c88b5d48af.

Please find attached files. :)

Regards,
Tatsuro Yamada

Commits

Fix progress reporting of CLUSTER / VACUUM FULL
- 6212276e4343 13.0 landed
- da47e43dc32e 12.0 landed
Fix thinko when ending progress report for a backend
- f4b91a50e9e6 9.6.16 landed
- 4950f09e7ae2 10.11 landed
- af28744288b1 11.6 landed
- 4c3e750ab4b5 12.0 landed
- ae060a52b288 13.0 landed
Report progress of REINDEX operations
- 03f9e5cba0ee 12.0 cited
Add progress reporting for CLUSTER and VACUUM FULL.
- 6f97457e0ddd 12.0 landed
Un-hide most cascaded-drop details in regression test results.
- 940311e4bb32 12.0 cited
Fix memory leak in printtup.c.
- f2004f19ed9c 12.0 cited
Remove unused macro
- fb5806533f9f 12.0 cited