Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove unused field from SubPlanState struct

  1. Cleanup SubPlanstate

    Rafia Sabih <rafia.pghackers@gmail.com> — 2024-10-29T14:34:41Z

    Hello hackers,

While reviewing a related patch, it came to the notice that tab_eq_funcs in
the SubPlanState is not used. Hence the patch.

-- 
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH

  2. Re: Cleanup SubPlanstate

    Andrei Lepikhov <lepihov@gmail.com> — 2024-10-30T02:44:52Z

    On 10/29/24 21:34, Rafia Sabih wrote:
> Hello hackers,
> 
> While reviewing a related patch, it came to the notice that tab_eq_funcs 
> in the SubPlanState is not used. Hence the patch.
Ok.
My initial doubt in such cases is - may it be the case where we mask a 
mistake? But that case looks good. Introduced in ab05eed, the approach 
with an equality function for each grouping column was replaced by 
bf6c614, which moved the grouping operation execution via the expression 
evaluation machinery. That made the tab_eq_funcs useless.
So, I think it may be removed.

-- 
regards, Andrei Lepikhov

  3. Re: Cleanup SubPlanstate

    David Rowley <dgrowleyml@gmail.com> — 2024-10-31T00:49:29Z

    On Wed, 30 Oct 2024 at 03:34, Rafia Sabih <rafia.pghackers@gmail.com> wrote:
> While reviewing a related patch, it came to the notice that tab_eq_funcs in the SubPlanState is not used. Hence the patch.

Thanks for picking that up. I didn't quite understand why you adjusted
the header comment for the TupleHashEntryData struct when the field
you removed was in the SubPlanState struct, so I left that part out.
However, I did fix the existing typo in that comment.

I've pushed the resulting patch.

David