Re: Cleanup SubPlanstate

Andrei Lepikhov <lepihov@gmail.com>

From: Andrei Lepikhov <lepihov@gmail.com>

To: Rafia Sabih <rafia.pghackers@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Cc: David Rowley <dgrowleyml@gmail.com>

Date: 2024-10-30T02:44:52Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove unused field from SubPlanState struct
- 3974bc319639 18.0 landed

On 10/29/24 21:34, Rafia Sabih wrote:
> Hello hackers,
> 
> While reviewing a related patch, it came to the notice that tab_eq_funcs 
> in the SubPlanState is not used. Hence the patch.
Ok.
My initial doubt in such cases is - may it be the case where we mask a 
mistake? But that case looks good. Introduced in ab05eed, the approach 
with an equality function for each grouping column was replaced by 
bf6c614, which moved the grouping operation execution via the expression 
evaluation machinery. That made the tab_eq_funcs useless.
So, I think it may be removed.

-- 
regards, Andrei Lepikhov