Thread

1. superfluous copydir() prototype in pg_upgrade.h

   Robert Haas <robertmhaas@gmail.com> — 2010-07-01T14:32:59Z

   While looking at Guillaume Lelarge's patch to add
   CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
   have a $SUBJECT.
   
   Trivial patch attached.
   
   -- 
   Robert Haas
   EnterpriseDB: http://www.enterprisedb.com
   The Enterprise Postgres Company
   

2. Re: superfluous copydir() prototype in pg_upgrade.h

   Tom Lane <tgl@sss.pgh.pa.us> — 2010-07-01T14:35:45Z

   Robert Haas <robertmhaas@gmail.com> writes:
   > While looking at Guillaume Lelarge's patch to add
   > CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
   > have a $SUBJECT.
   
   > Trivial patch attached.
   
   The rmtree() declaration below it shouldn't be there either ...
   
   			regards, tom lane
   
   

3. Re: superfluous copydir() prototype in pg_upgrade.h

   Bruce Momjian <bruce@momjian.us> — 2010-07-01T14:37:57Z

   Tom Lane wrote:
   > Robert Haas <robertmhaas@gmail.com> writes:
   > > While looking at Guillaume Lelarge's patch to add
   > > CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
   > > have a $SUBJECT.
   > 
   > > Trivial patch attached.
   > 
   > The rmtree() declaration below it shouldn't be there either ...
   
   When pg_upgrade was not in /contrib, I was concerned about including
   port.h, but at this point, I think it is fine.  Both removed.
   
   -- 
     Bruce Momjian  <bruce@momjian.us>        http://momjian.us
     EnterpriseDB                             http://enterprisedb.com
   
     + None of us is going to be here forever. +