Horton
Menu

Re: superfluous copydir() prototype in pg_upgrade.h

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-07-01T14:37:57Z
Lists: pgsql-hackers 
Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > While looking at Guillaume Lelarge's patch to add
> > CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
> > have a $SUBJECT.
> 
> > Trivial patch attached.
> 
> The rmtree() declaration below it shouldn't be there either ...

When pg_upgrade was not in /contrib, I was concerned about including
port.h, but at this point, I think it is fine.  Both removed.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +