Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

David E. Wheeler <david@justatheory.com>

From: "David E. Wheeler" <david@justatheory.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Bruce Momjian <bruce@momjian.us>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>, Mankirat Singh <mankiratsingh1315@gmail.com>

Date: 2025-10-29T23:13:32Z

Lists: pgsql-hackers

On Oct 29, 2025, at 17:37, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> In the past we've never really thought that ABI was more than mildly
> solidified until around rc1.  On the whole I'd rather wait until after
> the branch before starting to check ABI, simply because I don't care
> for the idea of adding .abi-compliance-history in the master branch
> only to remove it again later.  Having said that, it would be good
> if we *could* choose to do that, so I still do not like having any
> policy decisions about which branches to check hard-wired into the
> buildfarm client.

Well that’s pretty easily addressed by adding a configuration for it. Maybe a regex to match branches, defaulting to its current value[0], `/_STABLE$/`.

D

[0]: https://github.com/MankiratSingh1315/pg-bf-client-code/blob/abi-comp-check/PGBuild/Modules/ABICompCheck.pm#L248