Horton

Thread

Commits

  1. Remove some dead code in contrib/adminpack/

  1. Dead code in adminpack

    Antonin Houska <ah@cybertec.at> — 2020-02-13T11:15:39Z

    I've noticed that convert_and_check_filename() is always passed false for the
"logAllowed" argument - someone probably forgot to remove the argument when it
was decided that log files are no longer accepted. If the argument was removed,
the function would become a bit simpler, see the patch.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

  2. Re: Dead code in adminpack

    Julien Rouhaud <rjuju123@gmail.com> — 2020-02-13T11:41:46Z

    On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah@cybertec.at> wrote:
>
> I've noticed that convert_and_check_filename() is always passed false for the
> "logAllowed" argument - someone probably forgot to remove the argument when it
> was decided that log files are no longer accepted. If the argument was removed,
> the function would become a bit simpler, see the patch.

Indeed, and actually I don't see when this codepath was reachable.

Patch LGTM.

  3. Re: Dead code in adminpack

    Michael Paquier <michael@paquier.xyz> — 2020-02-13T11:45:28Z

    On Thu, Feb 13, 2020 at 12:15:39PM +0100, Antonin Houska wrote:
> I've noticed that convert_and_check_filename() is always passed false for the
> "logAllowed" argument - someone probably forgot to remove the argument when it
> was decided that log files are no longer accepted. If the argument was removed,
> the function would become a bit simpler, see the patch.

This routine was originally named absClusterPath(), but even at its
origin point (fe59e56) this argument has never been used.  So no
objections to clean up that.
--
Michael

  4. Re: Dead code in adminpack

    Michael Paquier <michael@paquier.xyz> — 2020-02-14T03:44:03Z

    On Thu, Feb 13, 2020 at 12:41:46PM +0100, Julien Rouhaud wrote:
> On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah@cybertec.at> wrote:
>> I've noticed that convert_and_check_filename() is always passed false for the
>> "logAllowed" argument - someone probably forgot to remove the argument when it
>> was decided that log files are no longer accepted. If the argument was removed,
>> the function would become a bit simpler, see the patch.
> 
> Indeed, and actually I don't see when this codepath was reachable.
> 
> Patch LGTM.

Thanks, applied.
--
Michael