Re: Dead code in adminpack
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Antonin Houska <ah@cybertec.at>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-02-14T03:44:03Z
Lists: pgsql-hackers
On Thu, Feb 13, 2020 at 12:41:46PM +0100, Julien Rouhaud wrote: > On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah@cybertec.at> wrote: >> I've noticed that convert_and_check_filename() is always passed false for the >> "logAllowed" argument - someone probably forgot to remove the argument when it >> was decided that log files are no longer accepted. If the argument was removed, >> the function would become a bit simpler, see the patch. > > Indeed, and actually I don't see when this codepath was reachable. > > Patch LGTM. Thanks, applied. -- Michael
Commits
-
Remove some dead code in contrib/adminpack/
- 11f063b0a974 13.0 landed