Thread

  1. removing some dead "keep compiler quiet" code

    Peter Eisentraut <peter_e@gmx.net> — 2012-11-20T03:45:56Z

    Since ereport() can now communicate to the compiler whether it returns
    or not, a fair amount of "keep compiler quiet" code is dead.  Since the
    method that ereport() uses is not dependent on any compiler-specific
    attributes, I think this code can just be removed.  I propose the
    attached patch.
    
  2. Re: removing some dead "keep compiler quiet" code

    Tom Lane <tgl@sss.pgh.pa.us> — 2012-11-20T04:09:44Z

    Peter Eisentraut <peter_e@gmx.net> writes:
    > Since ereport() can now communicate to the compiler whether it returns
    > or not, a fair amount of "keep compiler quiet" code is dead.  Since the
    > method that ereport() uses is not dependent on any compiler-specific
    > attributes, I think this code can just be removed.  I propose the
    > attached patch.
    
    Meh.  This will only work if the compiler understands that abort()
    doesn't return --- compilers that don't know that will start bleating
    about uninitialized variables again.  And the ones that do know it
    will be able to throw away the dead code anyway.
    
    I doubt this is a good idea.
    
    			regards, tom lane