removing some dead "keep compiler quiet" code

Since ereport() can now communicate to the compiler whether it returns
or not, a fair amount of "keep compiler quiet" code is dead.  Since the
method that ereport() uses is not dependent on any compiler-specific
attributes, I think this code can just be removed.  I propose the
attached patch.