Horton

Thread

Commits

  1. Remove obsolete speculative insert cleanup in ReorderBuffer.

  2. Fix decoding of speculative aborts.

  1. Dead code in logical decoding of speculative insertions

    Antonin Houska <ah@cybertec.at> — 2026-03-05T09:29:41Z

    Since commit 4daa140a2f50 adds the INTERNAL_SPEC_ABORT change, I think it's no
longer necessary to care about "pending speculations" at the time we receive
the next INTERNAL_SPEC_INSERT change.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

  2. Re: Dead code in logical decoding of speculative insertions

    Amit Kapila <amit.kapila16@gmail.com> — 2026-03-06T09:38:09Z

    On Thu, Mar 5, 2026 at 2:59 PM Antonin Houska <ah@cybertec.at> wrote:
>
> Since commit 4daa140a2f50 adds the INTERNAL_SPEC_ABORT change, I think it's no
> longer necessary to care about "pending speculations" at the time we receive
> the next INTERNAL_SPEC_INSERT change.
>

Right, I also think so. Did you find it via code review or some other way?

-- 
With Regards,
Amit Kapila.

  3. Re: Dead code in logical decoding of speculative insertions

    Antonin Houska <ah@cybertec.at> — 2026-03-06T09:53:38Z

    Amit Kapila <amit.kapila16@gmail.com> wrote:

> On Thu, Mar 5, 2026 at 2:59 PM Antonin Houska <ah@cybertec.at> wrote:
> >
> > Since commit 4daa140a2f50 adds the INTERNAL_SPEC_ABORT change, I think it's no
> > longer necessary to care about "pending speculations" at the time we receive
> > the next INTERNAL_SPEC_INSERT change.
> >
> 
> Right, I also think so. Did you find it via code review or some other way?

Yes, I noticed that via code review, while investigating a crash:

[1] https://www.postgresql.org/message-id/CAFC%2Bb6o2yzA80YmfEhmMO9puN8qvGRvr-15BBLn3UmJxPfpr2w%40mail.gmail.com

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com