Horton

Re: Dead code in logical decoding of speculative insertions

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Antonin Houska <ah@cybertec.at>
Cc: pgsql-hackers@lists.postgresql.org, akapila@postgresql.org
Date: 2026-03-06T09:38:09Z
Lists: pgsql-hackers 
On Thu, Mar 5, 2026 at 2:59 PM Antonin Houska <ah@cybertec.at> wrote:
>
> Since commit 4daa140a2f50 adds the INTERNAL_SPEC_ABORT change, I think it's no
> longer necessary to care about "pending speculations" at the time we receive
> the next INTERNAL_SPEC_INSERT change.
>

Right, I also think so. Did you find it via code review or some other way?

-- 
With Regards,
Amit Kapila.

Commits

  1. Remove obsolete speculative insert cleanup in ReorderBuffer.

  2. Fix decoding of speculative aborts.