Make prep_status() message translatable

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>

To: pgsql-hackers@lists.postgresql.org

Date: 2025-04-07T06:55:46Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Make pg_upgrade log message with control file path translatable.
- 3aad76a0a970 18.0 landed
Use XLOG_CONTROL_FILE macro consistently for control file name.
- 173c97812ffc 18.0 cited

Attachments

0001-Make-prep_status-message-translatable.patch (text/x-patch)

Hello,

The recent commit 173c97812ff made the following change:

-	prep_status("Adding \".old\" suffix to old global/pg_control");
+	prep_status("Adding \".old\" suffix to old " XLOG_CONTROL_FILE);

This change results in a message that is untranslatable, at least into
Japanese.  In addition, the file name should be quoted.

The attached patch modifies the message to use %s for XLOG_CONTROL_FILE,  
making it properly translatable.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center