Horton

Thread

Commits

  1. Standardize type of extend_by counter

  2. bufmgr: Introduce infrastructure for faster relation extension

  1. Standardize type of variable when extending Buffers

    Ranier Vilela <ranier.vf@gmail.com> — 2023-07-07T13:11:39Z

    Hi,

This has already been discussed in [1].
But I thought it best to start a new thread.

The commit 31966b1
<https://github.com/postgres/postgres/commit/31966b151e6ab7a6284deab6e8fe5faddaf2ae4c>
introduced the infrastructure to extend
buffers.
But the patch mixed types with int and uint32.
The correct type of the variable counter is uint32.

Fix by standardizing the int type to uint32.

patch attached.

best regards,
Ranier Vilela

[1]
https://www.postgresql.org/message-id/CAEudQAr_oWHpZk4uumZijYS362gp4KHAah-yUe08CQY4a4SsOQ%40mail.gmail.com

  2. Re: Standardize type of variable when extending Buffers

    Gurjeet Singh <gurjeet@singh.im> — 2023-07-07T18:29:16Z

    On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Hi,
>
> This has already been discussed in [1].
> But I thought it best to start a new thread.
>
> The commit 31966b1 introduced the infrastructure to extend
> buffers.
> But the patch mixed types with int and uint32.
> The correct type of the variable counter is uint32.
>
> Fix by standardizing the int type to uint32.
>
> patch attached.

LGTM.

+CC Kyotaro, as they were involved in the previous discussion.

>
> [1] https://www.postgresql.org/message-id/CAEudQAr_oWHpZk4uumZijYS362gp4KHAah-yUe08CQY4a4SsOQ%40mail.gmail.com


Best regards,
Gurjeet
http://Gurje.et

  3. Re: Standardize type of variable when extending Buffers

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2023-07-10T06:27:37Z

    At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh <gurjeet@singh.im> wrote in 
> On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier.vf@gmail.com> wrote:
> >
> > Hi,
> >
> > This has already been discussed in [1].
> > But I thought it best to start a new thread.
> >
> > The commit 31966b1 introduced the infrastructure to extend
> > buffers.
> > But the patch mixed types with int and uint32.
> > The correct type of the variable counter is uint32.
> >
> > Fix by standardizing the int type to uint32.
> >
> > patch attached.
> 
> LGTM.

LGTM, too.

I don't think it will actually come to play, since I believe we won't
be expanding a relation by 16TB all at once. Nevertheless, I believe
keeping things tidy is a good habit to stick to.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  4. Re: Standardize type of variable when extending Buffers

    Ranier Vilela <ranier.vf@gmail.com> — 2023-07-10T11:08:36Z

    Em seg., 10 de jul. de 2023 às 03:27, Kyotaro Horiguchi <
horikyota.ntt@gmail.com> escreveu:

> At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh <gurjeet@singh.im> wrote
> in
> > On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier.vf@gmail.com>
> wrote:
> > >
> > > Hi,
> > >
> > > This has already been discussed in [1].
> > > But I thought it best to start a new thread.
> > >
> > > The commit 31966b1 introduced the infrastructure to extend
> > > buffers.
> > > But the patch mixed types with int and uint32.
> > > The correct type of the variable counter is uint32.
> > >
> > > Fix by standardizing the int type to uint32.
> > >
> > > patch attached.
> >
> > LGTM.
>
> LGTM, too.
>
Thanks Gurjeet and Kyotaro, for taking a look.


> I don't think it will actually come to play, since I believe we won't
> be expanding a relation by 16TB all at once. Nevertheless, I believe
> keeping things tidy is a good habit to stick to.
>
Yeah, mainly because of copy-and-paste.
Also, compiler has to promote int to uint32, anyway.

regards,
Ranier Vilela

  5. Re: Standardize type of variable when extending Buffers

    Peter Eisentraut <peter@eisentraut.org> — 2023-09-19T08:07:49Z

    On 10.07.23 13:08, Ranier Vilela wrote:
> 
> Em seg., 10 de jul. de 2023 às 03:27, Kyotaro Horiguchi 
> <horikyota.ntt@gmail.com <mailto:horikyota.ntt@gmail.com>> escreveu:
> 
>     At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh <gurjeet@singh.im
>     <mailto:gurjeet@singh.im>> wrote in
>      > On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier.vf@gmail.com
>     <mailto:ranier.vf@gmail.com>> wrote:
>      > >
>      > > Hi,
>      > >
>      > > This has already been discussed in [1].
>      > > But I thought it best to start a new thread.
>      > >
>      > > The commit 31966b1 introduced the infrastructure to extend
>      > > buffers.
>      > > But the patch mixed types with int and uint32.
>      > > The correct type of the variable counter is uint32.
>      > >
>      > > Fix by standardizing the int type to uint32.
>      > >
>      > > patch attached.
>      >
>      > LGTM.
> 
>     LGTM, too.
> 
> Thanks Gurjeet and Kyotaro, for taking a look.

committed

  6. Re: Standardize type of variable when extending Buffers

    Ranier Vilela <ranier.vf@gmail.com> — 2023-09-19T11:29:51Z

    Em ter., 19 de set. de 2023 às 05:07, Peter Eisentraut <peter@eisentraut.org>
escreveu:

> On 10.07.23 13:08, Ranier Vilela wrote:
> >
> > Em seg., 10 de jul. de 2023 às 03:27, Kyotaro Horiguchi
> > <horikyota.ntt@gmail.com <mailto:horikyota.ntt@gmail.com>> escreveu:
> >
> >     At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh <gurjeet@singh.im
> >     <mailto:gurjeet@singh.im>> wrote in
> >      > On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier.vf@gmail.com
> >     <mailto:ranier.vf@gmail.com>> wrote:
> >      > >
> >      > > Hi,
> >      > >
> >      > > This has already been discussed in [1].
> >      > > But I thought it best to start a new thread.
> >      > >
> >      > > The commit 31966b1 introduced the infrastructure to extend
> >      > > buffers.
> >      > > But the patch mixed types with int and uint32.
> >      > > The correct type of the variable counter is uint32.
> >      > >
> >      > > Fix by standardizing the int type to uint32.
> >      > >
> >      > > patch attached.
> >      >
> >      > LGTM.
> >
> >     LGTM, too.
> >
> > Thanks Gurjeet and Kyotaro, for taking a look.
>
> committed
>
Thank you Peter.

best regards,
Ranier Vilela