Re: Standardize type of variable when extending Buffers

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Ranier Vilela <ranier.vf@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: gurjeet@singh.im, pgsql-hackers@postgresql.org
Date: 2023-09-19T08:07:49Z
Lists: pgsql-hackers
On 10.07.23 13:08, Ranier Vilela wrote:
> 
> Em seg., 10 de jul. de 2023 às 03:27, Kyotaro Horiguchi 
> <horikyota.ntt@gmail.com <mailto:horikyota.ntt@gmail.com>> escreveu:
> 
>     At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh <gurjeet@singh.im
>     <mailto:gurjeet@singh.im>> wrote in
>      > On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier.vf@gmail.com
>     <mailto:ranier.vf@gmail.com>> wrote:
>      > >
>      > > Hi,
>      > >
>      > > This has already been discussed in [1].
>      > > But I thought it best to start a new thread.
>      > >
>      > > The commit 31966b1 introduced the infrastructure to extend
>      > > buffers.
>      > > But the patch mixed types with int and uint32.
>      > > The correct type of the variable counter is uint32.
>      > >
>      > > Fix by standardizing the int type to uint32.
>      > >
>      > > patch attached.
>      >
>      > LGTM.
> 
>     LGTM, too.
> 
> Thanks Gurjeet and Kyotaro, for taking a look.

committed




Commits

  1. Standardize type of extend_by counter

  2. bufmgr: Introduce infrastructure for faster relation extension