Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove unused-and-misspelled function extern declaration.

  2. Allow users to limit storage reserved by replication slots

  1. definition of CalculateMaxmumSafeLSN

    Sergei Kornilov <sk@zsrv.org> — 2022-02-28T14:01:10Z

    Hello
I just spotted in src/include/access/xlog.h:
extern XLogRecPtr CalculateMaxmumSafeLSN(void);

This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.
Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"

regards, Sergei

  2. Re: definition of CalculateMaxmumSafeLSN

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-03-01T01:11:03Z

    At Mon, 28 Feb 2022 17:01:10 +0300, Sergei Kornilov <sk@zsrv.org> wrote in 
> Hello
> I just spotted in src/include/access/xlog.h:
> extern XLogRecPtr CalculateMaxmumSafeLSN(void);
> 
> This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.
> Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"

Hmm.  I think I remember of that name. You're right, it is a function
that was once added during development of the commit but eventually
gone.

So it should be removed.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  3. Re: definition of CalculateMaxmumSafeLSN

    Julien Rouhaud <rjuju123@gmail.com> — 2022-03-01T04:44:40Z

    Hi,

On Tue, Mar 01, 2022 at 10:11:03AM +0900, Kyotaro Horiguchi wrote:
> At Mon, 28 Feb 2022 17:01:10 +0300, Sergei Kornilov <sk@zsrv.org> wrote in 
> > Hello
> > I just spotted in src/include/access/xlog.h:
> > extern XLogRecPtr CalculateMaxmumSafeLSN(void);
> > 
> > This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.
> > Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"
> 
> Hmm.  I think I remember of that name. You're right, it is a function
> that was once added during development of the commit but eventually
> gone.
> 
> So it should be removed.

+1.  I'm Ccing Álvaro as he's the committer.

  4. Re: definition of CalculateMaxmumSafeLSN

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2022-05-21T11:12:20Z

    On Mon, Feb 28, 2022 at 7:31 PM Sergei Kornilov <sk@zsrv.org> wrote:
>
> Hello
> I just spotted in src/include/access/xlog.h:
> extern XLogRecPtr CalculateMaxmumSafeLSN(void);
>
> This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.
> Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"

+1 to remove. Although the change is straightforward, I attached the
patch just for the sake of convention. I've marked it as RfC
https://commitfest.postgresql.org/38/3616/.

Just for the record - there's another thread
https://www.postgresql.org/message-id/CALj2ACVoQ7NEf43Xz0rfxsGOKYTN5r4VZp2DO2_5p%2BCMzsRPFw%40mail.gmail.com

Regards,
Bharath Rupireddy.

  5. Re: definition of CalculateMaxmumSafeLSN

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-05-21T17:27:12Z

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
> On Mon, Feb 28, 2022 at 7:31 PM Sergei Kornilov <sk@zsrv.org> wrote:
>> I just spotted in src/include/access/xlog.h:
>> extern XLogRecPtr CalculateMaxmumSafeLSN(void);
>> This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.

> +1 to remove.

Right, done.

			regards, tom lane