Re: definition of CalculateMaxmumSafeLSN

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>

To: sk@zsrv.org

Cc: pgsql-hackers@postgresql.org

Date: 2022-03-01T01:11:03Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove unused-and-misspelled function extern declaration.
- e19272ef603b 15.0 landed
Allow users to limit storage reserved by replication slots
- c6550776394e 13.0 cited

At Mon, 28 Feb 2022 17:01:10 +0300, Sergei Kornilov <sk@zsrv.org> wrote in 
> Hello
> I just spotted in src/include/access/xlog.h:
> extern XLogRecPtr CalculateMaxmumSafeLSN(void);
> 
> This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.
> Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"

Hmm.  I think I remember of that name. You're right, it is a function
that was once added during development of the commit but eventually
gone.

So it should be removed.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center