Horton

Thread

Commits

  1. Correct some uses of e.g. and i.e. in message strings and documentation

  1. i.e. and e.g.

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-07-13T09:09:43Z

    I happened to see the message below.

> WARNING:  new data directory should not be inside the old data directory, e.g. %s

The corresponding code is

> ... the old data directory, e.g. %s", old_cluster_pgdata);

So, "e.g." (for example) in the message sounds like "that is", which I
think is "i.e.".  It should be fixed if this is correct.  I'm not sure
whether to keep using Latin-origin acronyms like this, but in the
attached I used "i.e.".

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  2. Re: i.e. and e.g.

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-07-13T09:13:51Z

    At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> I happened to see the message below.
> 
> > WARNING:  new data directory should not be inside the old data directory, e.g. %s
> 
> The corresponding code is
> 
> > ... the old data directory, e.g. %s", old_cluster_pgdata);
> 
> So, "e.g." (for example) in the message sounds like "that is", which I
> think is "i.e.".  It should be fixed if this is correct.  I'm not sure
> whether to keep using Latin-origin acronyms like this, but in the
> attached I used "i.e.".

Oops! There's another use of that word in the same context.
Attached contains two fixes.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  3. Re: i.e. and e.g.

    Junwang Zhao <zhjwpku@gmail.com> — 2022-07-13T09:21:20Z

    make sense.

+1

On Wed, Jul 13, 2022 at 5:14 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
> > I happened to see the message below.
> >
> > > WARNING:  new data directory should not be inside the old data directory, e.g. %s
> >
> > The corresponding code is
> >
> > > ... the old data directory, e.g. %s", old_cluster_pgdata);
> >
> > So, "e.g." (for example) in the message sounds like "that is", which I
> > think is "i.e.".  It should be fixed if this is correct.  I'm not sure
> > whether to keep using Latin-origin acronyms like this, but in the
> > attached I used "i.e.".
>
> Oops! There's another use of that word in the same context.
> Attached contains two fixes.
>
> regards.
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center



-- 
Regards
Junwang Zhao

  4. Re: i.e. and e.g.

    Aleksander Alekseev <aleksander@timescale.com> — 2022-07-13T09:25:32Z

    Hi Kyotaro,

> Oops! There's another use of that word in the same context.
> Attached contains two fixes.

Good catch. I did a quick search for similar messages and apparently
there are no others to fix.

-- 
Best regards,
Aleksander Alekseev

  5. Re: i.e. and e.g.

    John Naylor <john.naylor@enterprisedb.com> — 2022-07-14T02:40:25Z

    On Wed, Jul 13, 2022 at 4:13 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:
>
> At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <
horikyota.ntt@gmail.com> wrote in
> > I happened to see the message below.
> >
> > > WARNING:  new data directory should not be inside the old data
directory, e.g. %s
> >
> > The corresponding code is
> >
> > > ... the old data directory, e.g. %s", old_cluster_pgdata);
> >
> > So, "e.g." (for example) in the message sounds like "that is", which I
> > think is "i.e.".  It should be fixed if this is correct.  I'm not sure
> > whether to keep using Latin-origin acronyms like this, but in the
> > attached I used "i.e.".

I did my own quick scan and found one use of i.e. that doesn't really fit,
in a sentence that has other grammatical issues:

-        Due to the differences how ECPG works compared to Informix's
ESQL/C (i.e., which steps
+        Due to differences in how ECPG works compared to Informix's ESQL/C
(namely, which steps
         are purely grammar transformations and which steps rely on the
underlying run-time library)
         there is no <literal>FREE cursor_name</literal> statement in ECPG.
This is because in ECPG,
         <literal>DECLARE CURSOR</literal> doesn't translate to a function
call into

I've pushed that in addition to your changes, thanks!

--
John Naylor
EDB: http://www.enterprisedb.com

  6. Re: i.e. and e.g.

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-07-14T06:38:37Z

    At Thu, 14 Jul 2022 09:40:25 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in 
> On Wed, Jul 13, 2022 at 4:13 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> wrote:
> >
> > At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <
> horikyota.ntt@gmail.com> wrote in
> > > So, "e.g." (for example) in the message sounds like "that is", which I
> > > think is "i.e.".  It should be fixed if this is correct.  I'm not sure
> > > whether to keep using Latin-origin acronyms like this, but in the
> > > attached I used "i.e.".
> 
> I did my own quick scan and found one use of i.e. that doesn't really fit,
> in a sentence that has other grammatical issues:
> 
> -        Due to the differences how ECPG works compared to Informix's
> ESQL/C (i.e., which steps
> +        Due to differences in how ECPG works compared to Informix's ESQL/C
> (namely, which steps
>          are purely grammar transformations and which steps rely on the

Oh!

> I've pushed that in addition to your changes, thanks!

Thanks!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  7. Re: i.e. and e.g.

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-07-20T08:40:50Z

    At Thu, 14 Jul 2022 15:38:37 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> At Thu, 14 Jul 2022 09:40:25 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in 
> > On Wed, Jul 13, 2022 at 4:13 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> > wrote:
> > >
> > > At Wed, 13 Jul 2022 18:09:43 +0900 (JST), Kyotaro Horiguchi <
> > horikyota.ntt@gmail.com> wrote in
> > > > So, "e.g." (for example) in the message sounds like "that is", which I
> > > > think is "i.e.".  It should be fixed if this is correct.  I'm not sure
> > > > whether to keep using Latin-origin acronyms like this, but in the
> > > > attached I used "i.e.".
> > 
> > I did my own quick scan and found one use of i.e. that doesn't really fit,
> > in a sentence that has other grammatical issues:
> > 
> > -        Due to the differences how ECPG works compared to Informix's
> > ESQL/C (i.e., which steps
> > +        Due to differences in how ECPG works compared to Informix's ESQL/C
> > (namely, which steps
> >          are purely grammar transformations and which steps rely on the
> 
> Oh!
> 
> > I've pushed that in addition to your changes, thanks!
> 
> Thanks!

By the way, I forgot about back-branches. Don't we need to fix the
same in back-branches?

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  8. Re: i.e. and e.g.

    John Naylor <john.naylor@enterprisedb.com> — 2022-07-21T03:20:30Z

    On Wed, Jul 20, 2022 at 3:40 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:
> By the way, I forgot about back-branches. Don't we need to fix the
> same in back-branches?

The intent of the messages is pretty clear to me, so I don't really see a
need to change back branches. It does make sense for v15, though, and I
just forgot to consider that.

--
John Naylor
EDB: http://www.enterprisedb.com

  9. Re: i.e. and e.g.

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-07-21T04:22:35Z

    At Thu, 21 Jul 2022 10:20:30 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in 
> On Wed, Jul 20, 2022 at 3:40 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> wrote:
> > By the way, I forgot about back-branches. Don't we need to fix the
> > same in back-branches?
> 
> The intent of the messages is pretty clear to me, so I don't really see a
> need to change back branches. It does make sense for v15, though, and I
> just forgot to consider that.

Ok, I'm fine with that. Thanks!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  10. Re: i.e. and e.g.

    John Naylor <john.naylor@enterprisedb.com> — 2022-07-21T05:30:04Z

    On Thu, Jul 21, 2022 at 11:22 AM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:
>
> At Thu, 21 Jul 2022 10:20:30 +0700, John Naylor <
john.naylor@enterprisedb.com> wrote in
> > On Wed, Jul 20, 2022 at 3:40 PM Kyotaro Horiguchi <
horikyota.ntt@gmail.com>
> > wrote:
> > > By the way, I forgot about back-branches. Don't we need to fix the
> > > same in back-branches?
> >
> > The intent of the messages is pretty clear to me, so I don't really see
a
> > need to change back branches. It does make sense for v15, though, and I
> > just forgot to consider that.
>
> Ok, I'm fine with that. Thanks!

This is done.

--
John Naylor
EDB: http://www.enterprisedb.com

  11. Re: i.e. and e.g.

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-07-21T08:48:02Z

    At Thu, 21 Jul 2022 12:30:04 +0700, John Naylor <john.naylor@enterprisedb.com> wrote in 
> On Thu, Jul 21, 2022 at 11:22 AM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> wrote:
> >
> > At Thu, 21 Jul 2022 10:20:30 +0700, John Naylor <
> john.naylor@enterprisedb.com> wrote in
> > > need to change back branches. It does make sense for v15, though, and I
> > > just forgot to consider that.
> >
> > Ok, I'm fine with that. Thanks!
> 
> This is done.

Thanks!

-- 
Kyotaro Horiguchi
NTT Open Source Software Center