Horton

Thread

Commits

  1. Reorder COMPRESSION option in gram.y and parsenodes.h into alphabetical order.

  2. doc: Add missing COMPRESSION into CREATE TABLE synopsis.

  1. INCLUDING COMPRESSION

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-04-14T14:46:58Z

    The syntax for like_option in CREATE TABLE docs seems to forget to mention
INCLUDING COMPRESSION option. I think the following fix is necessary.
Patch attached.

-{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
+{ INCLUDING | EXCLUDING } { COMMENTS | COMPRESSION | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  2. Re: INCLUDING COMPRESSION

    Michael Paquier <michael@paquier.xyz> — 2021-04-15T02:54:58Z

    On Wed, Apr 14, 2021 at 11:46:58PM +0900, Fujii Masao wrote:
> The syntax for like_option in CREATE TABLE docs seems to forget to mention
> INCLUDING COMPRESSION option. I think the following fix is necessary.
> Patch attached.
> 
> -{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
> +{ INCLUDING | EXCLUDING } { COMMENTS | COMPRESSION | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }

Indeed.  May I ask at the same time why gram.y (TableLikeOption) and
parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
option in alphabetical order with the rest?  Ordering them makes
easier a review of them.
--
Michael

  3. Re: INCLUDING COMPRESSION

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-04-15T14:24:07Z

    
On 2021/04/15 11:54, Michael Paquier wrote:
> On Wed, Apr 14, 2021 at 11:46:58PM +0900, Fujii Masao wrote:
>> The syntax for like_option in CREATE TABLE docs seems to forget to mention
>> INCLUDING COMPRESSION option. I think the following fix is necessary.
>> Patch attached.
>>
>> -{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
>> +{ INCLUDING | EXCLUDING } { COMMENTS | COMPRESSION | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
> 
> Indeed.

Thanks! Pushed.

>  May I ask at the same time why gram.y (TableLikeOption) and
> parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
> option in alphabetical order with the rest?  Ordering them makes
> easier a review of them.

I'm not sure why. But +1 to make them in alphabetical order.
Patch attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  4. Re: INCLUDING COMPRESSION

    Michael Paquier <michael@paquier.xyz> — 2021-04-16T01:20:17Z

    On Thu, Apr 15, 2021 at 11:24:07PM +0900, Fujii Masao wrote:
> I'm not sure why. But +1 to make them in alphabetical order.
> Patch attached.

LGTM.
--
Michael

  5. Re: INCLUDING COMPRESSION (sort enum fields)

    Justin Pryzby <pryzby@telsasoft.com> — 2021-04-22T23:51:23Z

    (moved to -hackers)

https://www.postgresql.org/message-id/flat/54d30e66-dbd6-5485-aaf6-a291ed55919d%40oss.nttdata.com

On Thu, Apr 15, 2021 at 11:24:07PM +0900, Fujii Masao wrote:
> On 2021/04/15 11:54, Michael Paquier wrote:
> >  May I ask at the same time why gram.y (TableLikeOption) and
> > parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
> > option in alphabetical order with the rest?  Ordering them makes
> > easier a review of them.
> 
> I'm not sure why. But +1 to make them in alphabetical order.
> Patch attached.

+1 to your patch

-- 
Justin

  6. Re: INCLUDING COMPRESSION

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-04-23T10:11:53Z

    
On 2021/04/16 10:20, Michael Paquier wrote:
> On Thu, Apr 15, 2021 at 11:24:07PM +0900, Fujii Masao wrote:
>> I'm not sure why. But +1 to make them in alphabetical order.
>> Patch attached.
> 
> LGTM.

Pushed. Thanks!

Regards,


-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION