Horton

Re: INCLUDING COMPRESSION (sort enum fields)

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
Date: 2021-04-22T23:51:23Z
Lists: pgsql-hackers, pgsql-docs

Attachments

(moved to -hackers)

https://www.postgresql.org/message-id/flat/54d30e66-dbd6-5485-aaf6-a291ed55919d%40oss.nttdata.com

On Thu, Apr 15, 2021 at 11:24:07PM +0900, Fujii Masao wrote:
> On 2021/04/15 11:54, Michael Paquier wrote:
> >  May I ask at the same time why gram.y (TableLikeOption) and
> > parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
> > option in alphabetical order with the rest?  Ordering them makes
> > easier a review of them.
> 
> I'm not sure why. But +1 to make them in alphabetical order.
> Patch attached.

+1 to your patch

-- 
Justin

Commits

  1. Reorder COMPRESSION option in gram.y and parsenodes.h into alphabetical order.

  2. doc: Add missing COMPRESSION into CREATE TABLE synopsis.