Re: BUG #16953: OOB access while converting "interval" to char
Julien Rouhaud <rjuju123@gmail.com>
From: Julien Rouhaud <rjuju123@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: t.larionov@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Date: 2021-04-12T03:13:02Z
Lists: pgsql-bugs
On Mon, Apr 12, 2021 at 12:04:23PM +0900, Michael Paquier wrote: > On Fri, Apr 09, 2021 at 07:58:51PM +0900, Michael Paquier wrote: > > Yep. The regression tests show what I would expect. I'll check in > > details later. > > I have spent some time on that today and applied this patch down to > 9.6, after adding more comments and simplifying a bit the calculation > method used. Instead of using the "mon" variable to store an > intermediate result, I have simplified things so as this only uses > tm->tm_mon, and "mon" for the position in the roman-numeral array is > adjusted only once. Thanks Michael! I thought we'd want to keep the original calculation for consistency, but directly computing the needed offset is clearly simpler to read!
Commits
-
Fix out-of-bound memory access for interval -> char conversion
- 6540322fad8b 9.6.22 landed
- 1cc110f68dcc 10.17 landed
- 5656f2c3dce5 11.12 landed
- 82dd5706ee5a 12.7 landed
- be79debd9688 13.3 landed
- 7a3972597f6e 14.0 landed