Horton

Thread

Commits

  1. Fix function name in comment.

  2. Mention pg_promote() as a method to trigger promotion in documentation.

  1. It is not documented that pg_promote can exit standby mode

    Masahiro Ikeda <ikedamsh@oss.nttdata.com> — 2020-04-17T04:11:31Z

    Hi, 

The document(high-availability.sgml) says that there are only two ways 
to exit standby mode.

　26.2.2. Standby Server Operation
　Standby mode is exited and the server switches to normal operation when 
pg_ctl promote is run or a trigger file is found (promote_trigger_file).

But there is another way, by calling pg_promote function.
I think we need to document it, doesn't it?

I attached a patch. Please review and let me know your thoughts.

Regards,
Masahiro Ikeda

  2. Re: It is not documented that pg_promote can exit standby mode

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-04-17T04:40:02Z

    
On 2020/04/17 13:11, ikedamsh wrote:
> Hi,
> 
> The document(high-availability.sgml) says that there are only two ways to exit standby mode.
> 
> 　26.2.2. Standby Server Operation
> 　Standby mode is exited and the server switches to normal operation when pg_ctl promote is run or a trigger file is found (promote_trigger_file).
> 
> But there is another way, by calling pg_promote function.
> I think we need to document it, doesn't it?
> 
> I attached a patch. Please review and let me know your thoughts.

Thanks for the report and the patch! It looks good to me.
Barring any objection, I will commit this patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  3. Re: It is not documented that pg_promote can exit standby mode

    Michael Paquier <michael@paquier.xyz> — 2020-04-17T04:54:39Z

    On Fri, Apr 17, 2020 at 01:40:02PM +0900, Fujii Masao wrote:
> Thanks for the report and the patch! It looks good to me.
> Barring any objection, I will commit this patch.

+1.
--
Michael

  4. Re: It is not documented that pg_promote can exit standby mode

    Laurenz Albe <laurenz.albe@cybertec.at> — 2020-04-17T06:51:15Z

    On Fri, 2020-04-17 at 13:54 +0900, Michael Paquier wrote:
> On Fri, Apr 17, 2020 at 01:40:02PM +0900, Fujii Masao wrote:
> > Thanks for the report and the patch! It looks good to me.
> > Barring any objection, I will commit this patch.
> 
> +1.

+1.  That was my omission in the original patch.

Yours,
Laurenz Albe

  5. Re: It is not documented that pg_promote can exit standby mode

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-04-17T17:46:37Z

    Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> Thanks for the report and the patch! It looks good to me.
> Barring any objection, I will commit this patch.

It might be worth writing "<function>pg_promote()</function> is called"
(adding parentheses) to make it clearer that a function is being
referred to.  No objection otherwise.

			regards, tom lane

  6. Re: It is not documented that pg_promote can exit standby mode

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-04-20T11:38:36Z

    
On 2020/04/18 2:46, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> Thanks for the report and the patch! It looks good to me.
>> Barring any objection, I will commit this patch.
> 
> It might be worth writing "<function>pg_promote()</function> is called"
> (adding parentheses) to make it clearer that a function is being
> referred to.  No objection otherwise.

Yes. Also Masahiro-san reported me, off-list, that there are other places
where pg_promote is mentioned without parentheses. I think it's better to
add parentheses there. Attached is the updated version of the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  7. Re: It is not documented that pg_promote can exit standby mode

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-04-21T05:07:09Z

    
On 2020/04/20 20:38, Fujii Masao wrote:
> 
> 
> On 2020/04/18 2:46, Tom Lane wrote:
>> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>>> Thanks for the report and the patch! It looks good to me.
>>> Barring any objection, I will commit this patch.
>>
>> It might be worth writing "<function>pg_promote()</function> is called"
>> (adding parentheses) to make it clearer that a function is being
>> referred to.  No objection otherwise.
> 
> Yes. Also Masahiro-san reported me, off-list, that there are other places
> where pg_promote is mentioned without parentheses. I think it's better to
> add parentheses there. Attached is the updated version of the patch.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  8. change a function name in a comment correctly

    Masahiro Ikeda <ikedamsh@oss.nttdata.com> — 2020-07-07T02:50:10Z

    Hi,

There is the comment which related function name is not same.
I attached the patch to fix it. Please review.

Regards,

-- 
Masahiro Ikeda
NTT DATA CORPORATION

  9. Re: change a function name in a comment correctly

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-07-07T03:00:30Z

    
On 2020/07/07 11:50, Masahiro Ikeda wrote:
> Hi,
> 
> There is the comment which related function name is not same.
> I attached the patch to fix it. Please review.

Thanks for the report and patch! LGTM.
I will commit this later.

Regards,


-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  10. Re: change a function name in a comment correctly

    Masahiro Ikeda <ikedamsh@oss.nttdata.com> — 2020-07-07T23:12:45Z

    >> There is the comment which related function name is not same.
>> I attached the patch to fix it. Please review.
> 
> Thanks for the report and patch! LGTM.
> I will commit this later.

Thanks for checking.

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION

  11. Re: change a function name in a comment correctly

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-07-08T02:01:46Z

    
On 2020/07/08 8:12, Masahiro Ikeda wrote:
>>> There is the comment which related function name is not same.
>>> I attached the patch to fix it. Please review.
>>
>> Thanks for the report and patch! LGTM.
>> I will commit this later.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION