Re: It is not documented that pg_promote can exit standby mode
Fujii Masao <masao.fujii@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: ikedamsh <ikedamsh@oss.nttdata.com>, pgsql-hackers@postgresql.org
Date: 2020-04-21T05:07:09Z
Lists: pgsql-hackers
On 2020/04/20 20:38, Fujii Masao wrote: > > > On 2020/04/18 2:46, Tom Lane wrote: >> Fujii Masao <masao.fujii@oss.nttdata.com> writes: >>> Thanks for the report and the patch! It looks good to me. >>> Barring any objection, I will commit this patch. >> >> It might be worth writing "<function>pg_promote()</function> is called" >> (adding parentheses) to make it clearer that a function is being >> referred to. No objection otherwise. > > Yes. Also Masahiro-san reported me, off-list, that there are other places > where pg_promote is mentioned without parentheses. I think it's better to > add parentheses there. Attached is the updated version of the patch. Pushed. Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
Commits
-
Fix function name in comment.
- 5e574d170e2e 14.0 landed
-
Mention pg_promote() as a method to trigger promotion in documentation.
- 67f82e966b52 13.0 landed