Horton

Thread

Commits

  1. Remove argument isprimary from index_build()

  1. index_build does not need its isprimary argument

    Michael Paquier <michael@paquier.xyz> — 2019-01-22T08:08:52Z

    Hi all,

While working on REINDEX CONCURRENTLY, I have noticed that
index_build() does not need its argument isprimary.  Perhaps it is
not worth bothering, but for the REINDEX CONCURRENTLY business this
removes the need to open an index when triggering a concurrent
build.

The flag was introduced in 3fdeb189, but f66e8bf actually forgot to
finish the cleanup as index_update_stats() has simplified its
interface.

Are there any objections if I cleanup that stuff as per the attached?

Thanks,
--
Michael

  2. Re: index_build does not need its isprimary argument

    Michael Paquier <michael@paquier.xyz> — 2019-01-23T23:02:44Z

    On Tue, Jan 22, 2019 at 05:08:52PM +0900, Michael Paquier wrote:
> While working on REINDEX CONCURRENTLY, I have noticed that
> index_build() does not need its argument isprimary.  Perhaps it is
> not worth bothering, but for the REINDEX CONCURRENTLY business this
> removes the need to open an index when triggering a concurrent
> build.
> 
> The flag was introduced in 3fdeb189, but f66e8bf actually forgot to
> finish the cleanup as index_update_stats() has simplified its
> interface.

And committed as of 289198c, and back to the real deal..
--
Michael