Horton

index_build does not need its isprimary argument

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2019-01-22T08:08:52Z
Lists: pgsql-hackers

Attachments

Hi all,

While working on REINDEX CONCURRENTLY, I have noticed that
index_build() does not need its argument isprimary.  Perhaps it is
not worth bothering, but for the REINDEX CONCURRENTLY business this
removes the need to open an index when triggering a concurrent
build.

The flag was introduced in 3fdeb189, but f66e8bf actually forgot to
finish the cleanup as index_update_stats() has simplified its
interface.

Are there any objections if I cleanup that stuff as per the attached?

Thanks,
--
Michael

Commits

  1. Remove argument isprimary from index_build()