Horton

Thread

Commits

  1. Update reference to sampling algorithm in analyze.c

  2. Separate block sampling functions

  1. Obsolete comment in commands/analyze.c

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2019-06-27T11:05:36Z

    Hi,

I think commit 83e176ec1, which moved block sampling functions to
utils/misc/sampling.c, forgot to update this comment in
commands/analyze.c: "This algorithm is from Jeff Vitter's paper (see
full citation below)"; since the citation was also moved to
utils/misc/sampling.c, I think the "see full citation below" part
should be updated accordingly.  Attached is a patch for that.

Best regards,
Etsuro Fujita

  2. Re: Obsolete comment in commands/analyze.c

    Daniel Gustafsson <daniel@yesql.se> — 2019-06-27T11:53:52Z

    > On 27 Jun 2019, at 13:05, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:

> since the citation was also moved to
> utils/misc/sampling.c, I think the "see full citation below" part
> should be updated accordingly.  Attached is a patch for that.

Agreed, nice catch!

cheers ./daniel

  3. Re: Obsolete comment in commands/analyze.c

    Tomas Vondra <tomas.vondra@2ndquadrant.com> — 2019-06-27T16:02:51Z

    On Thu, Jun 27, 2019 at 01:53:52PM +0200, Daniel Gustafsson wrote:
>> On 27 Jun 2019, at 13:05, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>
>> since the citation was also moved to
>> utils/misc/sampling.c, I think the "see full citation below" part
>> should be updated accordingly.  Attached is a patch for that.
>
>Agreed, nice catch!
>

Thanks, committed.


cheers

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  4. Re: Obsolete comment in commands/analyze.c

    Etsuro Fujita <etsuro.fujita@gmail.com> — 2019-06-28T04:00:12Z

    On Fri, Jun 28, 2019 at 1:02 AM Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
> On Thu, Jun 27, 2019 at 01:53:52PM +0200, Daniel Gustafsson wrote:
> >> On 27 Jun 2019, at 13:05, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >
> >> since the citation was also moved to
> >> utils/misc/sampling.c, I think the "see full citation below" part
> >> should be updated accordingly.  Attached is a patch for that.
> >
> >Agreed, nice catch!
>
> Thanks, committed.

Thanks for committing, Tomas!  Thanks for reviewing, Daniel!

Best regards,
Etsuro Fujita