Horton

Re: Obsolete comment in commands/analyze.c

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-06-28T04:00:12Z
Lists: pgsql-hackers 
On Fri, Jun 28, 2019 at 1:02 AM Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
> On Thu, Jun 27, 2019 at 01:53:52PM +0200, Daniel Gustafsson wrote:
> >> On 27 Jun 2019, at 13:05, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >
> >> since the citation was also moved to
> >> utils/misc/sampling.c, I think the "see full citation below" part
> >> should be updated accordingly.  Attached is a patch for that.
> >
> >Agreed, nice catch!
>
> Thanks, committed.

Thanks for committing, Tomas!  Thanks for reviewing, Daniel!

Best regards,
Etsuro Fujita

Commits

  1. Update reference to sampling algorithm in analyze.c

  2. Separate block sampling functions