Horton

Thread

Commits

  1. Flip argument order in XLogSegNoOffsetToRecPtr

  2. Make WAL segment size configurable at initdb time.

  1. XLogSegNoOffsetToRecPtr fixup

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2018-07-08T18:23:45Z

    Pursuant to closing comment in 
https://postgr.es/m/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
here's a quick patch to change the order of arguments in
XLogSegNoOffsetToRecPtr.  Commit fc49e24fa69a ("Make WAL segment size
configurable at initdb time.") put the walsegsz as last argument,
*after* its output argument, which is downright weird.

I propose to apply this to pg11 and master, to avoid an unnecessary API
change in pg12.

-- 
Álvaro Herrera                         http://www.flickr.com/photos/alvherre/

  2. Re: XLogSegNoOffsetToRecPtr fixup

    Andres Freund <andres@anarazel.de> — 2018-07-08T18:27:49Z

    Hi,

On 2018-07-08 14:23:45 -0400, Alvaro Herrera wrote:
> Pursuant to closing comment in 
> https://postgr.es/m/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
> here's a quick patch to change the order of arguments in
> XLogSegNoOffsetToRecPtr.  Commit fc49e24fa69a ("Make WAL segment size
> configurable at initdb time.") put the walsegsz as last argument,
> *after* its output argument, which is downright weird.
> 
> I propose to apply this to pg11 and master, to avoid an unnecessary API
> change in pg12.

WFM.

Thanks,

Andres