Horton

XLogSegNoOffsetToRecPtr fixup

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Date: 2018-07-08T18:23:45Z
Lists: pgsql-hackers

Attachments

Pursuant to closing comment in 
https://postgr.es/m/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
here's a quick patch to change the order of arguments in
XLogSegNoOffsetToRecPtr.  Commit fc49e24fa69a ("Make WAL segment size
configurable at initdb time.") put the walsegsz as last argument,
*after* its output argument, which is downright weird.

I propose to apply this to pg11 and master, to avoid an unnecessary API
change in pg12.

-- 
Álvaro Herrera                         http://www.flickr.com/photos/alvherre/

Commits

  1. Flip argument order in XLogSegNoOffsetToRecPtr

  2. Make WAL segment size configurable at initdb time.