Horton

Thread

Commits

  1. Remove dedicated B-tree root-split record types.

  2. Make the handling of interrupted B-tree page splits more robust.

  1. [PATCH] Remove unused argument in btree_xlog_split

    Aleksander Alekseev <a.alekseev@postgrespro.ru> — 2017-03-31T14:10:56Z

    Hi,

Turned out that there is an unused argument `isroot` in
`btree_xlog_split` procedure. Suggested patch fixes it.

This issue was discovered by Anastasia Lubennikova, coding is done by me.

-- 
Best regards,
Aleksander Alekseev

  2. Re: [PATCH] Remove unused argument in btree_xlog_split

    Robert Haas <robertmhaas@gmail.com> — 2017-04-05T16:05:48Z

    On Fri, Mar 31, 2017 at 10:10 AM, Aleksander Alekseev
<a.alekseev@postgrespro.ru> wrote:
> Turned out that there is an unused argument `isroot` in
> `btree_xlog_split` procedure. Suggested patch fixes it.
>
> This issue was discovered by Anastasia Lubennikova, coding is done by me.

Hmm.  I don't see anything wrong with that, particularly, but it seems
we also don't need the distinction between XLOG_BTREE_SPLIT_L and
XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
a little further and do all of that together.

It looks like this is fallout from Heikki's 2014 commit
40dae7ec537c5619fc93ad602c62f37be786d161, which removed
log_incomplete_split().

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  3. Re: [PATCH] Remove unused argument in btree_xlog_split

    Aleksander Alekseev <a.alekseev@postgrespro.ru> — 2017-04-06T12:21:17Z

    Hi Robert,

> Hmm.  I don't see anything wrong with that, particularly, but it seems
> we also don't need the distinction between XLOG_BTREE_SPLIT_L and
> XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
> XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
> a little further and do all of that together.

Thank you for sharing your thoughts on this patch. Here is a new
version.

-- 
Best regards,
Aleksander Alekseev

  4. Re: [PATCH] Remove unused argument in btree_xlog_split

    Robert Haas <robertmhaas@gmail.com> — 2017-04-07T18:21:02Z

    On Thu, Apr 6, 2017 at 8:21 AM, Aleksander Alekseev
<a.alekseev@postgrespro.ru> wrote:
> Hi Robert,
>
>> Hmm.  I don't see anything wrong with that, particularly, but it seems
>> we also don't need the distinction between XLOG_BTREE_SPLIT_L and
>> XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
>> XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
>> a little further and do all of that together.
>
> Thank you for sharing your thoughts on this patch. Here is a new
> version.

Thanks.  Please add this to the next CommitFest, as there seems to be
no urgency (and some risk) in committing it right before feature
freeze.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  5. Re: [PATCH] Remove unused argument in btree_xlog_split

    Aleksander Alekseev <a.alekseev@postgrespro.ru> — 2017-04-09T13:25:16Z

    Hi Robert,

> Thanks.  Please add this to the next CommitFest, as there seems to be
> no urgency (and some risk) in committing it right before feature
> freeze.

Sure. Already done [1].

[1] https://commitfest.postgresql.org/14/1097/

-- 
Best regards,
Aleksander Alekseev

  6. Re: [PATCH] Remove unused argument in btree_xlog_split

    Heikki Linnakangas <hlinnaka@iki.fi> — 2017-08-16T09:28:20Z

    On 04/06/2017 03:21 PM, Aleksander Alekseev wrote:
> Hi Robert,
> 
>> Hmm.  I don't see anything wrong with that, particularly, but it seems
>> we also don't need the distinction between XLOG_BTREE_SPLIT_L and
>> XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
>> XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
>> a little further and do all of that together.
> 
> Thank you for sharing your thoughts on this patch. Here is a new
> version.

Committed, thanks.

- Heikki