Horton

Re: [PATCH] Remove unused argument in btree_xlog_split

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Date: 2017-04-05T16:05:48Z
Lists: pgsql-hackers 
On Fri, Mar 31, 2017 at 10:10 AM, Aleksander Alekseev
<a.alekseev@postgrespro.ru> wrote:
> Turned out that there is an unused argument `isroot` in
> `btree_xlog_split` procedure. Suggested patch fixes it.
>
> This issue was discovered by Anastasia Lubennikova, coding is done by me.

Hmm.  I don't see anything wrong with that, particularly, but it seems
we also don't need the distinction between XLOG_BTREE_SPLIT_L and
XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
a little further and do all of that together.

It looks like this is fallout from Heikki's 2014 commit
40dae7ec537c5619fc93ad602c62f37be786d161, which removed
log_incomplete_split().

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove dedicated B-tree root-split record types.

  2. Make the handling of interrupted B-tree page splits more robust.