Horton

Thread

Commits

  1. pkg-config Requires.private entries should be comma-separated

  1. pkg-config Requires.private entries should be comma-separated

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2023-03-15T07:51:04Z

    While comparing the .pc (pkg-config) files generated by the make and 
meson builds, I noticed that the Requires.private entries use different 
delimiters.  The make build uses spaces, the meson build uses commas. 
The pkg-config documentation says that it should be comma-separated, but 
apparently about half the .pc in the wild use just spaces.

The pkg-config source code acknowledges that both commas and spaces work:

https://github.com/freedesktop/pkg-config/blob/master/parse.c#L273
https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/dependency.c#L286

I think for consistency we should change the make build to use commas 
anyway.  See attached patch.

  2. Re: pkg-config Requires.private entries should be comma-separated

    Andres Freund <andres@anarazel.de> — 2023-03-15T16:10:14Z

    Hi,

On 2023-03-15 08:51:04 +0100, Peter Eisentraut wrote:
> While comparing the .pc (pkg-config) files generated by the make and meson
> builds, I noticed that the Requires.private entries use different
> delimiters.  The make build uses spaces, the meson build uses commas. The
> pkg-config documentation says that it should be comma-separated, but
> apparently about half the .pc in the wild use just spaces.
> 
> The pkg-config source code acknowledges that both commas and spaces work:
> 
> https://github.com/freedesktop/pkg-config/blob/master/parse.c#L273
> https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/dependency.c#L286
> 
> I think for consistency we should change the make build to use commas
> anyway.  See attached patch.

Makes sense.

Greetings,

Andres Freund