pkg-config Requires.private entries should be comma-separated
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-15T07:51:04Z
Lists: pgsql-hackers
Attachments
- 0001-pkg-config-Requires.private-entries-should-be-comma-.patch (text/plain) patch 0001
While comparing the .pc (pkg-config) files generated by the make and meson builds, I noticed that the Requires.private entries use different delimiters. The make build uses spaces, the meson build uses commas. The pkg-config documentation says that it should be comma-separated, but apparently about half the .pc in the wild use just spaces. The pkg-config source code acknowledges that both commas and spaces work: https://github.com/freedesktop/pkg-config/blob/master/parse.c#L273 https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/dependency.c#L286 I think for consistency we should change the make build to use commas anyway. See attached patch.
Commits
-
pkg-config Requires.private entries should be comma-separated
- 4ef1be5a0b67 16.0 landed