Horton

Thread

Commits

  1. Rename PageData to GenericXLogPageData

  1. Rename PageData to XLogPageData

    Peter Eisentraut <peter@eisentraut.org> — 2024-10-02T11:30:46Z

    I was fiddling a bit with making some Page-related APIs const-proof, 
which might involve changing something like "Page p" to "const PageData 
*p", but I was surprised that a type PageData exists but it's an 
unrelated type local to generic_xlog.c.

This patch renames that type to a more specific name XLogPageData.  This 
makes room for possibly adding another PageData type with the earlier 
meaning, but that's not done here.  But I think even without that, this 
patch is a useful little cleanup that makes the code more consistent and 
clear.

  2. Re: Rename PageData to XLogPageData

    Heikki Linnakangas <hlinnaka@iki.fi> — 2024-10-02T17:02:06Z

    On 02/10/2024 14:30, Peter Eisentraut wrote:
> I was fiddling a bit with making some Page-related APIs const-proof, 
> which might involve changing something like "Page p" to "const PageData 
> *p", but I was surprised that a type PageData exists but it's an 
> unrelated type local to generic_xlog.c.

Good find

> This patch renames that type to a more specific name XLogPageData.  This 
> makes room for possibly adding another PageData type with the earlier 
> meaning, but that's not done here.  But I think even without that, this 
> patch is a useful little cleanup that makes the code more consistent and 
> clear.

+1 for renaming, but -1 on XLogPageData. That sounds like a WAL page, 
see XLogPageHeaderData for example. I'd suggest GenericXLogPageData or 
just GenericPerPageData or something.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

  3. Re: Rename PageData to XLogPageData

    Peter Eisentraut <peter@eisentraut.org> — 2024-10-03T11:31:19Z

    On 02.10.24 19:02, Heikki Linnakangas wrote:
>> This patch renames that type to a more specific name XLogPageData.  
>> This makes room for possibly adding another PageData type with the 
>> earlier meaning, but that's not done here.  But I think even without 
>> that, this patch is a useful little cleanup that makes the code more 
>> consistent and clear.
> 
> +1 for renaming, but -1 on XLogPageData. That sounds like a WAL page, 
> see XLogPageHeaderData for example. I'd suggest GenericXLogPageData or 
> just GenericPerPageData or something.

Sounds good.  Here is an updated version.

  4. Re: Rename PageData to XLogPageData

    Michael Paquier <michael@paquier.xyz> — 2024-10-04T03:55:45Z

    On Thu, Oct 03, 2024 at 01:31:19PM +0200, Peter Eisentraut wrote:
> Sounds good.  Here is an updated version.

Good idea.  What you have sent here looks good to me.
--
Michael

  5. Re: Rename PageData to XLogPageData

    Peter Eisentraut <peter@eisentraut.org> — 2024-10-04T11:02:04Z

    On 04.10.24 05:55, Michael Paquier wrote:
> On Thu, Oct 03, 2024 at 01:31:19PM +0200, Peter Eisentraut wrote:
>> Sounds good.  Here is an updated version.
> 
> Good idea.  What you have sent here looks good to me.

committed