Re: Rename PageData to XLogPageData

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-03T11:31:19Z
Lists: pgsql-hackers

Attachments

On 02.10.24 19:02, Heikki Linnakangas wrote:
>> This patch renames that type to a more specific name XLogPageData.  
>> This makes room for possibly adding another PageData type with the 
>> earlier meaning, but that's not done here.  But I think even without 
>> that, this patch is a useful little cleanup that makes the code more 
>> consistent and clear.
> 
> +1 for renaming, but -1 on XLogPageData. That sounds like a WAL page, 
> see XLogPageHeaderData for example. I'd suggest GenericXLogPageData or 
> just GenericPerPageData or something.

Sounds good.  Here is an updated version.

Commits

  1. Rename PageData to GenericXLogPageData