Thread

Re: Remove unused function parameters, part 2: replication

Daniel Gustafsson <daniel@yesql.se> — 2025-12-04T09:34:34Z

> On 2 Dec 2025, at 15:28, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:

> That said I'm still skeptical that we need to provide a strong
> justification (as the one above) to remove an unused parameter.

If it breaks an existing published API thus causing extensions to fail to
compile then IMHO that's a pretty strong argument against removing a parameter
even if it's unused, likewise if the change can be expected to cause
backpatching conflicts for the coming five years.  For static functions at
least it seems that compilers are fairly happy to remove the parameter in
greater than -O0 levels (though I know that won't move the needle on one of
your main drivers being readability).

--
Daniel Gustafsson