Re: Remove unused function parameters, part 2: replication
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
Andres Freund <andres@anarazel.de>,
pgsql-hackers@lists.postgresql.org
Date: 2025-12-04T09:34:34Z
Lists: pgsql-hackers
> On 2 Dec 2025, at 15:28, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote: > That said I'm still skeptical that we need to provide a strong > justification (as the one above) to remove an unused parameter. If it breaks an existing published API thus causing extensions to fail to compile then IMHO that's a pretty strong argument against removing a parameter even if it's unused, likewise if the change can be expected to cause backpatching conflicts for the coming five years. For static functions at least it seems that compilers are fairly happy to remove the parameter in greater than -O0 levels (though I know that won't move the needle on one of your main drivers being readability). -- Daniel Gustafsson