Horton

Thread

Commits

  1. Add const to values and nulls arguments

  1. Add const to values and nulls arguments

    Peter Eisentraut <peter@eisentraut.org> — 2023-10-06T13:11:50Z

    There are a lot of Datum *values, bool *nulls argument pairs that should 
really be const.  The 0001 patch makes those changes.  Some of these 
hunks depend on each other.

The 0002 patch, which I'm not proposing to commit at this time, makes 
similar changes but in a way that breaks the table and index AM APIs. 
So I'm just including that here in case anyone wonders, why didn't you 
touch those.  And also maybe if we ever change that API incompatibly we 
could throw this one in then.

  2. Re: Add const to values and nulls arguments

    Aleksander Alekseev <aleksander@timescale.com> — 2023-10-06T14:51:59Z

    Hi,

> There are a lot of Datum *values, bool *nulls argument pairs that should
> really be const.  The 0001 patch makes those changes.  Some of these
> hunks depend on each other.
>
> The 0002 patch, which I'm not proposing to commit at this time, makes
> similar changes but in a way that breaks the table and index AM APIs.
> So I'm just including that here in case anyone wonders, why didn't you
> touch those.  And also maybe if we ever change that API incompatibly we
> could throw this one in then.

0001 looks good to me and passes the tests in several environments,
not surprisingly. Let's merge it.

-- 
Best regards,
Aleksander Alekseev

  3. Re: Add const to values and nulls arguments

    Peter Eisentraut <peter@eisentraut.org> — 2023-10-10T05:57:00Z

    On 06.10.23 16:51, Aleksander Alekseev wrote:
>> There are a lot of Datum *values, bool *nulls argument pairs that should
>> really be const.  The 0001 patch makes those changes.  Some of these
>> hunks depend on each other.
>>
>> The 0002 patch, which I'm not proposing to commit at this time, makes
>> similar changes but in a way that breaks the table and index AM APIs.
>> So I'm just including that here in case anyone wonders, why didn't you
>> touch those.  And also maybe if we ever change that API incompatibly we
>> could throw this one in then.
> 
> 0001 looks good to me and passes the tests in several environments,
> not surprisingly. Let's merge it.

done

  4. Re: Add const to values and nulls arguments

    Aleksander Alekseev <aleksander@timescale.com> — 2023-10-10T09:14:26Z

    Hi,

> >> The 0002 patch, which I'm not proposing to commit at this time, makes
> >> similar changes but in a way that breaks the table and index AM APIs.
> >> So I'm just including that here in case anyone wonders, why didn't you
> >> touch those.  And also maybe if we ever change that API incompatibly we
> >> could throw this one in then.
> >
> > 0001 looks good to me and passes the tests in several environments,
> > not surprisingly. Let's merge it.
>
> done

Great. FWIW changing the index AM API in this particular aspect
doesn't strike me as such a terrible idea.

-- 
Best regards,
Aleksander Alekseev