Re: Add const to values and nulls arguments

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-10-10T05:57:00Z
Lists: pgsql-hackers
On 06.10.23 16:51, Aleksander Alekseev wrote:
>> There are a lot of Datum *values, bool *nulls argument pairs that should
>> really be const.  The 0001 patch makes those changes.  Some of these
>> hunks depend on each other.
>>
>> The 0002 patch, which I'm not proposing to commit at this time, makes
>> similar changes but in a way that breaks the table and index AM APIs.
>> So I'm just including that here in case anyone wonders, why didn't you
>> touch those.  And also maybe if we ever change that API incompatibly we
>> could throw this one in then.
> 
> 0001 looks good to me and passes the tests in several environments,
> not surprisingly. Let's merge it.

done




Commits

  1. Add const to values and nulls arguments