Re: WIP: log query in auto-explain
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2009-11-22T20:48:08Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes: > I put the attached together a while ago and neglected to send it. > Basically it includes the text of the query being explained in the > explain output. I'm pretty certain this will dump core in some contexts --- you should not assume that sourceText is always available. Should we be worried about security implications of displaying the query text? > I think it's more important to include the query text when using > auto_explain than in other explain uses, which is why I did it this way. > But I could be persuaded that we should always include it. I think this is just useless noise in every other case. regards, tom lane