Horton

Thread

Commits

  1. Remove unused argument "isSlice" from transformAssignmentSubscripts()

  2. Support subscripting of arbitrary types, not only arrays.

  1. Removed unused param isSlice of function transformAssignmentSubscripts

    Zhang Mingli <zmlpostgres@gmail.com> — 2022-09-13T03:35:37Z

    Hi,


Param isSlice was once used to identity targetTypeId for transformAssignmentIndirection.

In commit c7aba7c14e, the evaluation was pushed down to transformContainerSubscripts.

No need to keep isSlice around transformAssignmentSubscripts.

Attach a patch to remove it.

Regards,
Zhang Mingli

  2. Re: Removed unused param isSlice of function transformAssignmentSubscripts

    Richard Guo <guofenglinux@gmail.com> — 2022-09-13T07:20:01Z

    On Tue, Sep 13, 2022 at 11:35 AM Zhang Mingli <zmlpostgres@gmail.com> wrote:

> Param isSlice was once used to identity targetTypeId for
> transformAssignmentIndirection.
>
> In commit c7aba7c14e, the evaluation was pushed down to
> transformContainerSubscripts.
>
> No need to keep isSlice around transformAssignmentSubscripts.
>
> Attach a patch to remove it.
>

+1. Good catch.

Thanks
Richard

  3. Re: Removed unused param isSlice of function transformAssignmentSubscripts

    Michael Paquier <michael@paquier.xyz> — 2022-09-18T06:42:59Z

    On Tue, Sep 13, 2022 at 03:20:01PM +0800, Richard Guo wrote:
> +1. Good catch.

Yes, you are right that this comes from c7aba7c that has changed the
transform logic and the check on slicing support, and this makes the
code easier to follow.  So, applied.
--
Michael