Horton

Re: Removed unused param isSlice of function transformAssignmentSubscripts

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Zhang Mingli <zmlpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-13T07:20:01Z
Lists: pgsql-hackers 
On Tue, Sep 13, 2022 at 11:35 AM Zhang Mingli <zmlpostgres@gmail.com> wrote:

> Param isSlice was once used to identity targetTypeId for
> transformAssignmentIndirection.
>
> In commit c7aba7c14e, the evaluation was pushed down to
> transformContainerSubscripts.
>
> No need to keep isSlice around transformAssignmentSubscripts.
>
> Attach a patch to remove it.
>

+1. Good catch.

Thanks
Richard

Commits

  1. Remove unused argument "isSlice" from transformAssignmentSubscripts()

  2. Support subscripting of arbitrary types, not only arrays.