Horton

Remove emode argument from XLogFileRead() and XLogFileReadAnyTLI()

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: fba49d5293b4455b25485450baf02af42bf543d7
Author: Michael Paquier <michael@paquier.xyz>
Date: 2024-09-09T23:44:31Z
Releases: 18.0 
Remove emode argument from XLogFileRead() and XLogFileReadAnyTLI()

This change makes the code slightly easier to reason about, because
there is actually no need to know if a specific caller of one of these
routines should fail hard on a PANIC, or just let it go through with a
DEBUG2.

The only caller of XLogFileReadAnyTLI() used DEBUG2, and XLogFileRead()
has never used its emode.  This can be simplified since 1bb2558046cc
that has introduced XLogFileReadAnyTLI(), splitting both.

Author: Yugo Nagata
Discussion: https://postgr.es/m/20240906201043.a640f3b44e755d4db2b6943e@sraoss.co.jp

Files

PathChange+/−
src/backend/access/transam/xlogrecovery.c modified +9 −12

Discussion