Horton

Thread

Commits

  1. Remove emode argument from XLogFileRead() and XLogFileReadAnyTLI()

  1. Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

    Yugo Nagata <nagata@sraoss.co.jp> — 2024-09-06T11:10:43Z

    Hi,

Since 1bb2558046c, XLogFileRead() doesn't use the emode argument. 
Also, since abf5c5c9a4f, XLogFileReadAnyTLI() is called just once
and emode is always DEBUG2. So, I think we can remove the emode
argument from these functions. I've atached the patch.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

  2. Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

    Michael Paquier <michael@paquier.xyz> — 2024-09-09T03:16:01Z

    On Fri, Sep 06, 2024 at 08:10:43PM +0900, Yugo Nagata wrote:
> Since 1bb2558046c, XLogFileRead() doesn't use the emode argument. 
> Also, since abf5c5c9a4f, XLogFileReadAnyTLI() is called just once
> and emode is always DEBUG2. So, I think we can remove the emode
> argument from these functions. I've atached the patch.

It's true that the last relevant caller of XLogFileReadAnyTLI() that
required an emode is abf5c5c9a4f1, as you say, that's also what I am
tracking down.  Any objections to that?
--
Michael

  3. Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

    Yugo Nagata <nagata@sraoss.co.jp> — 2024-09-09T08:45:13Z

    On Mon, 9 Sep 2024 12:16:01 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> On Fri, Sep 06, 2024 at 08:10:43PM +0900, Yugo Nagata wrote:
> > Since 1bb2558046c, XLogFileRead() doesn't use the emode argument. 
> > Also, since abf5c5c9a4f, XLogFileReadAnyTLI() is called just once
> > and emode is always DEBUG2. So, I think we can remove the emode
> > argument from these functions. I've atached the patch.
> 
> It's true that the last relevant caller of XLogFileReadAnyTLI() that
> required an emode is abf5c5c9a4f1, as you say, that's also what I am
> tracking down.  Any objections to that?

Thank you for looking into this.

I mean to remove emode from XLogFileRead, too, but this fix is accidentally
missed in the previous patch. I attached the updated patch.

Regards,
Yugo Nagata

-- 
Yugo NAGATA <nagata@sraoss.co.jp>

  4. Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

    Michael Paquier <michael@paquier.xyz> — 2024-09-09T23:45:45Z

    On Mon, Sep 09, 2024 at 05:45:13PM +0900, Yugo NAGATA wrote:
> I mean to remove emode from XLogFileRead, too, but this fix is accidentally
> missed in the previous patch. I attached the updated patch.

This is neat because we don't need to guess how XLogFileRead() should
fail on PANIC, allow things with a DEBUG2 or something else, and
XLogFileReadAnyTLI()'s sole caller used DEBUG2.  Applied.
--
Michael