Fix violations of CatalogTupleInsert/Update/Delete abstraction.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: a571c7f661a7b601aafcb12196d004cdb8b8cb23
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-06-14T14:26:46Z
Releases: 10.0
Fix violations of CatalogTupleInsert/Update/Delete abstraction.

In commits 2f5c9d9c9 and ab0289651 we invented an abstraction layer
to insulate catalog manipulations from direct heap update calls.
But evidently some patches that hadn't landed in-tree at that point
didn't get the memo completely.  Fix a couple of direct calls to
simple_heap_delete to use CatalogTupleDelete instead; these appear
to have been added in commits 7c4f52409 and 7b504eb28.  This change is
purely cosmetic ATM, but there's no point in having an abstraction layer
if we allow random code to break it.

Masahiko Sawada and Tom Lane

Discussion: https://postgr.es/m/CAD21AoDOPRSVcwbnCN3Y1n_68ATyTspsU6=ygtHz_uY0VcdZ8A@mail.gmail.com

Files

PathChange+/−
src/backend/catalog/pg_subscription.c modified +1 −1
src/backend/commands/statscmds.c modified +2 −3

Discussion