Horton

Thread

Commits

  1. Fix violations of CatalogTupleInsert/Update/Delete abstraction.

  1. RemoveSubscriptionRel uses simple_heap_delete

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-06-14T06:54:08Z

    Hi,

Currently $subject but should we use CatalogTupleDelete() instead?
It's actually the same behavior though. Other functions use
CatalogTupleXXX(). Attached patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  2. Re: RemoveSubscriptionRel uses simple_heap_delete

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-06-14T13:44:47Z

    Masahiko Sawada <sawada.mshk@gmail.com> writes:
> Currently $subject but should we use CatalogTupleDelete() instead?
> It's actually the same behavior though. Other functions use
> CatalogTupleXXX(). Attached patch.

Yeah, evidently that patch failed to track the effects of commits
2f5c9d9c9 et al, since it wasn't in-tree yet.  Poking around, at
least statscmds.c has got the same disease.

			regards, tom lane

  3. Re: RemoveSubscriptionRel uses simple_heap_delete

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-06-14T17:41:59Z

    On Wed, Jun 14, 2017 at 10:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Masahiko Sawada <sawada.mshk@gmail.com> writes:
>> Currently $subject but should we use CatalogTupleDelete() instead?
>> It's actually the same behavior though. Other functions use
>> CatalogTupleXXX(). Attached patch.
>
> Yeah, evidently that patch failed to track the effects of commits
> 2f5c9d9c9 et al, since it wasn't in-tree yet.  Poking around, at
> least statscmds.c has got the same disease.
>

Thank you for fixing it!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center