Fix sign-compare warnings in pg_iovec.h.
Nathan Bossart <nathan@postgresql.org>
Fix sign-compare warnings in pg_iovec.h. The code in question (pg_preadv() and pg_pwritev()) has been around for a while, but commit 15c9ac3629 moved it to a header file. If third-party code that includes this header file is built with -Wsign-compare on a system without preadv() or pwritev(), warnings ensue. This commit fixes said warnings by casting the result of pg_pread()/pg_pwrite() to size_t, which should be safe because we will have already checked for a negative value. Author: Wolfgang Walther Discussion: https://postgr.es/m/16989737-1aa8-48fd-8dfe-b7ada06509ab%40technowledgy.de Backpatch-through: 17
Files
| Path | Change | +/− |
|---|---|---|
| src/include/port/pg_iovec.h | modified | +2 −2 |
Discussion
- Fix port/pg_iovec.h building extensions on x86_64-darwin 7 messages · 2024-11-08 → 2024-11-09