Re: Heads Up: cirrus-ci is shutting down June 1st

Hi,

On 2026-06-03 13:01:49 +0200, Peter Eisentraut wrote:
> There were a few tests/configurations that the FreeBSD job did under Cirrus
> that we didn't carry over yet.  I looked into this, and the attached patch
> fixes that.  Some of these tests are quite important, I think, so we should
> put those somewhere.

Agreed.


> I moved most of them over to macOS, mainly to keep them all together, since
> some things had already been moved there, and the overall run-time outcome
> from this seems reasonable.

Given the timings I see, I'd much rather move them to either linux-autoconf or
linux-meson-32. They're nearly twice as fast as macos right now.

Any reason against?


> The "Test running" step could probably be tweaked cosmetically a bit more.

Independent of this, it kinda seems like we should add a meson run target to
run the tests this way... Then this could be triggered more easily.


> I put in a YAML anchor so we could move it around or duplicate it more
> easily, but maybe that's not necessary or useful (and the use of the DYLD_*
> environment variable doesn't make it portable anyway).

That could be solved by setting LD_LIBRARY_PATH via the step's env:...


> Also, it's not clear if the "Stop running server" step is needed and exactly
> how it should be phrased to be most effective in this new environment.

> +      # FIXME This was needed on Cirrus, not clear if still needed on GHA.
> +      - name: Stop running server
> +        if: failure()
> +        run: |
> +          build/tmp_install/usr/local/pgsql/bin/pg_ctl -D build/runningcheck stop || true
> +

I don't think we need it in the case of failure, it should get terminated on
its own. I've seen that work a bunch of times with cancellations terminating
meson test without terminating the tests first. See e.g.
  https://github.com/anarazel/postgres/actions/runs/26869265453/job/79240470455
where you can see
  Cleaning up orphan processes
  Terminate orphan process: pid (54713) (psql)
  Terminate orphan process: pid (54704) (psql)
  Terminate orphan process: pid (54710) (psql)
  ...

Also, failure() as a condition, without !cancelled(), sometimes causes issues
due to not making the task auto-cancelable, which is annoying...


> From a067f35829f5db7b7b03d2ac1eed934820597a5c Mon Sep 17 00:00:00 2001
> From: Peter Eisentraut <peter@eisentraut.org>
> Date: Wed, 3 Jun 2026 12:47:35 +0200
> Subject: [PATCH v7.2.pe] Move more coverage from previously FreeBSD elsewhere
> 
> The following testing aspects were previously (Cirrus CI) covered by
> the FreeBSD job.  Since we currently (GitHub Actions) don't have
> FreeBSD support, we move these elsewhere for now:
> 
> - RELCACHE_FORCE_RELEASE (moved to macOS)
> - ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS (moved to macOS)
> - PG_TEST_INITDB_EXTRA_OPTS test reading/writing/copying of node trees
>   as well as debug_parallel_query=regress (moved to macOS)
> - PG_TEST_PG_UPGRADE_MODE --link (moved to Linux 64-bit (macOS already
>   tests --clone))

I'd move all of these to linux-autoconf, if you're ok with that?


> - meson test --setup running (moved to macOS)

And this to linux-meson-32?

Greetings,

Andres Freund